Whats betterFollow

Whats better for warriors pvp? One handed wep and Shield or 2h sword?>

Arms spec with a 2h weapon is generally accepted as the PVP spec.

I have been doing BGs on the prot warrior I am levelling and I'm not noticing much of a difference in damage when I go arms and I have some better survivability cooldowns.

I am, obviously.

Depends on your drops. Warriors are highly Dependant on gear. So you have base your play style around the strongest items. If you get lucky with a really nice H2 sword or shield drop, go with the best item until you get something better.