A warrior's professionFollow

It depends. Blacksmithing can do more than making weapons; you use grinding stones to increase your weapon damage for a certain amount of time. I just found that out ^_^.

Skinning/leatherworking wouldn't be worthless, but it wouldn't directly benefit you too much. The only things you might use would be bags and (maybe) cloaks (not sure). However, you get to sell everything you make, so you'll hopefully get money that way. If you're in a guild, and have a friend who is already a mining/blacksmith, then you really don't need that, but your guild might like some of your goods.

There are other ideas as well. First thing that comes to mind is alchemy/herbalism. Since Warriors don't have healing abilities, the ability to make good healing potions, along with +stat potions and magic protection potions, is a great benefit.

If you really just want secondary benefits to professions take two gathering professions. My Druid friend makes a ton as mining/herbalism.

In the end it's up to you. If it helps your guild, good for them. If not, it's your choice, not theirs, so poo poo to them!